[Openmp-commits] [PATCH] D155316: [OMPT] Fix use of 'DEBUG_PREFIX' in the OMPT headers

Sun Jul 16 11:46:29 PDT 2023

jhuber6 added a comment.

In D155316#4504378 <https://reviews.llvm.org/D155316#4504378>, @tianshilei1992 wrote:

> It seems like this patch introduced some new warnings:
>
>   In file included from /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp:22:
>   /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/OmptCallback.h:87:9: warning: pragma pop_macro could not pop 'DEBUG_PREFIX', no matching push_macro [-Wignored-pragmas]
>      87 | #pragma pop_macro("DEBUG_PREFIX")
>         |         ^
>   1 warning generated.
>   [46/54] Building CXX object libomptarget/plugins-nextgen/amdgpu/CMakeFiles/omptarget.rtl.amdgpu.dir/src/rtl.cpp.o
>   In file included from /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:26:
>   /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include/OmptCallback.h:87:9: warning: pragma pop_macro could not pop 'DEBUG_PREFIX', no matching push_macro [-Wignored-pragmas]
>      87 | #pragma pop_macro("DEBUG_PREFIX")
>         |         ^
>   1 warning generated.

Duh, forgot there was a second header guard for `OMPT_SUPPORT`. Didn't get that locally since I guess it's on. Simply needs to be moved before the penultimate `#endif`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155316/new/

https://reviews.llvm.org/D155316