[Openmp-commits] [PATCH] D155318: [OpenMP] Add documentation on using the `libc` in OpenMP

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

We really need to split openmp/docs/design/Runtimes.rst.

Generally LG. Please add a sentence and a link to the supported functions page.
Also, remove the two I flagged below.



================
Comment at: openmp/docs/design/Runtimes.rst:1355-1356
+image. When loading the device image, the runtime will check for this symbol and 
+initialize an RPC interface if it is found. If an RPC server is present, we will 
+run the server instead of blocking during synchronization events. The following 
+example shows the RPC server being used.
----------------
I would remove this sentence. It is too vague to be helpful.


================
Comment at: openmp/docs/design/Runtimes.rst:1367-1368
+
+This interface allows us to provide generic host services to the GPU and can 
+provide the basis of OpenMP reverse offloading.
+
----------------
Remove this, future looking statement w/o value now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155318/new/

https://reviews.llvm.org/D155318