[Openmp-commits] [PATCH] D154523: [OpenMP][AMDGPU] Tracking of busy HSA queues

[Kevin Sala via Phabricator via Openmp-commits]

kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1513
+    // Start the search from the starting index
+    for (int i = StartIndex; i < MaxNumQueues; ++i) {
+      Q = &Queues[i];
----------------
Also, `NextQueue` shouldn't be incremented while we advance in the search of non busy queues?


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1526
+    // Wrap around and continue search from the beginning
+    for (int i = 0; i < StartIndex; ++i) {
+      Q = &Queues[i];
----------------
I believe we can simplify and merge these two loops into a single one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154523/new/

https://reviews.llvm.org/D154523