[Openmp-commits] [PATCH] D154312: [Libomptarget] Begin implementing support for RPC services

[Matt Arsenault via Phabricator via Openmp-commits]

arsenm added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:1146
+  if (RPCServer)
+    delete RPCServer;
+
----------------
jhuber6 wrote:
> arsenm wrote:
> > Can you use unique_ptr?
> I was keeping it consistent with the `GlobalHandler` above. I think there was a specific reason for why we did that originally but I don't remember off the top of my head. Might've been something about ordering of the destructors.
Also don't need the null checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154312/new/

https://reviews.llvm.org/D154312