[Openmp-commits] [PATCH] D154523: [OpenMP][AMDGPU] Tracking of busy HSA queues

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1448
+    // Initialize one queue eagerly.
+    if (auto Err = Queues.front().init(Agent, QueueSize))
+      REPORT("Failure during first queue init: %s\n",
----------------
In case of error, I think we should report and return the error instead of reporting and keep going.

This is the initial queue, so if this fails, there is no queue available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154523/new/

https://reviews.llvm.org/D154523