[Openmp-commits] [PATCH] D154456: [Libomptarget] Correctly implement `getWTime` on AMDGPU

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 4 10:38:52 PDT 2023


jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp:833
+  /// Returns the clock frequency for the given NVPTX device.
+  uint64_t getClockFrequency() const override { return 1000000000; }
+
----------------
tianshilei1992 wrote:
> This doesn't need to be `1000000000UL`?
A 32-bit integer fits at least two billion, so we're just under here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154456/new/

https://reviews.llvm.org/D154456



More information about the Openmp-commits mailing list