[Openmp-commits] [PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28
+// OMP51: target: parallel
+// OMP51: target: parallel
+
----------------
This doesn't check much. You need to verify a 5th or print the team size. Same for the rest


================
Comment at: openmp/runtime/test/target/target_thread_limit.cpp:35
+// OMP51: target: parallel num_threads(2)
+
+// check whether thread_limit is honoured when there is a conflicting
----------------
Verify that the user can use the omp_set_ functions and see consistent behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152054/new/

https://reviews.llvm.org/D152054