[Openmp-commits] [PATCH] D142684: [OpenMP] Fix stack overflow for test bug54082.c

Fri Jan 27 05:34:36 PST 2023

mstorsjo added a comment.

In D142684#4085354 <https://reviews.llvm.org/D142684#4085354>, @tianshilei1992 wrote:

> In D142684#4084862 <https://reviews.llvm.org/D142684#4084862>, @mstorsjo wrote:
>
>> Thanks for the fix! It does indeed seem to fix the issue.
>>
>> Do you happen to know why this worked before, but now suddenly stopped working after D142297 <https://reviews.llvm.org/D142297> - was the stack usage so close to the edges of what's allowed, that any minor tweak pushed it over the limit, or did the change in D142297 <https://reviews.llvm.org/D142297> affect the amount of stack used in a bigger way? (I presume that the main `int result[N][N]` array here only gets allocated once on the stack, and the OpenMP threads just refer to that? I presume the change didn't cause the array to be allocated in more places than before?)
>
> There is no issue. That test case was added in that patch. It didn’t pass before…

Oh, I see - doh. Thanks for explaining and sorry for the noise!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142684/new/

https://reviews.llvm.org/D142684