[Openmp-commits] [PATCH] D142514: [OpenMP][libomptarget] Notify the plugins regarding new mapping/unmappings

Kevin Sala via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 26 17:08:04 PST 2023


kevinsala updated this revision to Diff 492603.
kevinsala added a comment.

Changes:

- Fixing comments.
- Re-writing the `PinnedAllocationMapTy` functions to be clearer and easier to read.
- Renaming RTL API functions.
- Disable automatic locking of mapped host buffers. Can be enabled by setting `LIBOMPTARGET_LOCK_MAPPED_HOST_BUFFERS` envar.
- Although the previous envar is not set, mapped buffers that were externally locked (e.g, the app allocating HSA memory) are registered into the plugin's map and we use a single-step asynchronous HSA memory transfer. (@ye-luo)

This patch still detects invalid partial overlapping in `offloading/complex_reduction.cpp`, which I have to fix. The previous patch fails with OpenMC, I've to check if this also fails.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142514/new/

https://reviews.llvm.org/D142514

Files:
  openmp/libomptarget/include/device.h
  openmp/libomptarget/include/omptargetplugin.h
  openmp/libomptarget/include/rtl.h
  openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
  openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp
  openmp/libomptarget/plugins-nextgen/generic-elf-64bit/src/rtl.cpp
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/src/rtl.cpp
  openmp/libomptarget/test/lit.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142514.492603.patch
Type: text/x-patch
Size: 33470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230127/9db79458/attachment-0001.bin>


More information about the Openmp-commits mailing list