[Openmp-commits] [PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

Thu Jan 26 03:34:46 PST 2023

mstorsjo added a comment.

This change broke the `parallel/bug54082.c` testcase in the OpenMP runtime test set, when running on Windows (both mingw and MSVC configurations, and happening both in i386 and x86_64 builds), see e.g. https://github.com/mstorsjo/llvm-mingw/actions/runs/4011290068/jobs/6891673869. It's failing with error code `0xC00000FD`, which means `STATUS_STACK_OVERFLOW`. Is this change missing some aspect that differs between the unix and Windows ABIs?

So please don't backport this to the release branch right now. And I'd appreciate if you would consider to revert it if there's no immediately obvious fix in sight.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142297/new/

https://reviews.llvm.org/D142297