[Openmp-commits] [PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57
+  return !__omp_rtl_assume_no_nested_parallelism ||
+         state::getKernelEnvironment().Configuration.MayUseNestedParallelism;
 }
----------------
jdoerfert wrote:
> This looks wrong. We want either flag to allow us to remove nested parallelism handling. So 
> `__omp_rtl_assume_no_nested_parallelism ` is good enough, and
> `!state::getKernelEnvironment().Configuration.MayUseNestedParallelism` is good enough.
Yeah, since I already updated `OpenMPOpt.cpp`, `__omp_rtl_assume_no_nested_parallelism` will not be generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142569/new/

https://reviews.llvm.org/D142569