[Openmp-commits] [PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3479-3486
+  /// Return the IdentTy (ident_ty) corresponding to the associated kernel.
+  Constant *getKernelIdent(ConstantStruct *StructC) {
+    GlobalVariable *KernelEnvGV = getKernelEnvironementGlobalVariable();
+    auto *KernelEnvC = cast<ConstantStruct>(KernelEnvGV->getInitializer());
+    constexpr const unsigned IdentIdx = 1;
+    return KernelEnvC->getAggregateElement(IdentIdx);
+  }
----------------
arsenm wrote:
> Optimizations should be a separate change
That's gonna break the tests because the interfaces between compiler and runtime are changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142569/new/

https://reviews.llvm.org/D142569