[Openmp-commits] [PATCH] D142514: [OpenMP][libomptarget] Notify the plugins regarding new mapping/unmappings

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:797
+  auto PinnedPtrOrErr = PinnedAllocs.lockHostBuffer(
+      HstPtr, Size, /* check whether already locked */ true);
+  if (!PinnedPtrOrErr)
----------------
ye-luo wrote:
> I don't understand this part of code.
> The implementation actually lock the host buffer instead of just notifying.
While it is mapped, we want to keep it (by default) pinned. The escape hatch (env var) is missing though.
This allows us to avoid the pin/unpin on the data transfer back and intermediate updates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142514/new/

https://reviews.llvm.org/D142514