[Openmp-commits] [PATCH] D142514: [OpenMP][libomptarget] Notify the plugins regarding new mapping/unmappings

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

I think this is fine. Two nits and Ye's comment need to be addressed. @tianshilei1992 please accept or suggest a different name. Since we really mean "OpenMP mapped" here, I find the name fitting.



================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1855
+        hsa_amd_pointer_info(HstPtr, &Info, /* Allocator */ nullptr,
+                             /* Number of accessible agents */ nullptr,
+                             /* Accessible agents */ nullptr);
----------------



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:487
+
+  virtual Expected<bool> isPinnedPtrImpl(void *HstPtr, void *&HstAllocPtr,
+                                         void *&DevAccessibleAllocPtr,
----------------
Docs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142514/new/

https://reviews.llvm.org/D142514