[Openmp-commits] [PATCH] D142514: [OpenMP][libomptarget] Notify the plugins regarding new mapping/unmappings

Tue Jan 24 16:57:22 PST 2023

tianshilei1992 added a comment.

In D142514#4078818 <https://reviews.llvm.org/D142514#4078818>, @kevinsala wrote:

> In D142514#4078741 <https://reviews.llvm.org/D142514#4078741>, @tianshilei1992 wrote:
>
>> mapped/unmapped is a confusing name, especially in the context of OpenMP, you can always check if a pointer is mapped in `libomptarget`. Of course I understand the "map" here is not OpenMP map.
>
> True. Any recommendation for the rename?

I'm working on Nvidia GPUs, so IMO pinned memory makes sense. Not sure if AMD people would object, though in the implementation you are using that name. ;-)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142514/new/

https://reviews.llvm.org/D142514