[Openmp-commits] [PATCH] D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins

Kevin Sala Penad├ęs via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 24 15:23:10 PST 2023


kevinsala added a comment.

In D141227#4078564 <https://reviews.llvm.org/D141227#4078564>, @jhuber6 wrote:

> If this fixes these failing with the nextgen plugins, please remove the line disabling the nextgen in the test.
>
>   Failed Tests (2):
>     libomptarget :: amdgcn-amd-amdhsa :: mapping/prelock.cpp
>     libomptarget :: amdgcn-amd-amdhsa-LTO :: mapping/prelock.cpp

It doesn't fix these tests because they are apparently wrong. We cannot map a device accessible buffer, which is the `agent_ptr` returned when locking the buffer. (More info: https://reviews.llvm.org/D142399). We can fix it using `is_device_ptr` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141227/new/

https://reviews.llvm.org/D141227



More information about the Openmp-commits mailing list