[Openmp-commits] [PATCH] D142378: [OpenMP][Archer] Use dlsym rather than weak symbols for TSan annotations

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

LG, assuming it fixes the problem and is not too much of a performance blow (the weak symbols will be resolved by the runtime loader, whereas we now do indirect function calls through pointers).

Out of curiosity (I came across this, but doesn't need to be addressed here): Is there a technical reason we implement `RunningOnValgrind` separately, not using the exact same `dlsym` infrastructure as for the TSan annotation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142378/new/

https://reviews.llvm.org/D142378