[Openmp-commits] [openmp] 2a8c9d7 - [Libomptarget] Use the nextgen plugins by default.

[Joseph Huber via Openmp-commits]

Author: Joseph Huber
Date: 2023-01-23T17:30:46-06:00
New Revision: 2a8c9d7c8abfa31487dd60eb7334aa94b64954b1

URL: https://github.com/llvm/llvm-project/commit/2a8c9d7c8abfa31487dd60eb7334aa94b64954b1
DIFF: https://github.com/llvm/llvm-project/commit/2a8c9d7c8abfa31487dd60eb7334aa94b64954b1.diff

LOG: [Libomptarget] Use the nextgen plugins by default.

The next-gen plugins are complete drop-in replacements for the old
versions. We should strive to replace the old ones as quickly as
possible now that we have a viable alternative.

The only test failing is the `prelock.cpp` test as the support has not landed in
the next-gen plugins.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D142399

Added: 
    

Modified: 
    openmp/libomptarget/src/rtl.cpp
    openmp/libomptarget/test/mapping/prelock.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/src/rtl.cpp b/openmp/libomptarget/src/rtl.cpp
index a2471506dde6f..230a8295c48b4 100644
--- a/openmp/libomptarget/src/rtl.cpp
+++ b/openmp/libomptarget/src/rtl.cpp
@@ -92,7 +92,7 @@ void RTLsTy::loadRTLs() {
 
   DP("Loading RTLs...\n");
 
-  BoolEnvar NextGenPlugins("LIBOMPTARGET_NEXTGEN_PLUGINS", false);
+  BoolEnvar NextGenPlugins("LIBOMPTARGET_NEXTGEN_PLUGINS", true);
 
   // Attempt to open all the plugins and, if they exist, check if the interface
   // is correct and if they are supporting any devices.

diff  --git a/openmp/libomptarget/test/mapping/prelock.cpp b/openmp/libomptarget/test/mapping/prelock.cpp
index 7d88e5864aa08..8e24c94f4a8ff 100644
--- a/openmp/libomptarget/test/mapping/prelock.cpp
+++ b/openmp/libomptarget/test/mapping/prelock.cpp
@@ -1,4 +1,5 @@
-// RUN: %libomptarget-compilexx-run-and-check-generic
+// RUN: %libomptarget-compilexx-generic
+// RUN: env LIBOMPTARGET_NEXTGEN_PLUGINS=0 %libomptarget-run-generic %fcheck-generic
 
 // UNSUPPORTED: aarch64-unknown-linux-gnu
 // UNSUPPORTED: aarch64-unknown-linux-gnu-LTO