[Openmp-commits] [PATCH] D142249: [openmp] Workaround for HSA in issue 60119

Sat Jan 21 00:10:24 PST 2023

Maetveis accepted this revision.
Maetveis added a comment.

Looks good, also works for my original program, thank you! Just one nit and a question:

Do we care about de-registration happening during init? It does not happen in the reproducer case when the dynamic loader loads the user libraries, but I think it could happen if one of the libraries HSA loads does a `dlopen` and `dlclose` in its constructor on a third library that's using OpenMP. Typed out like that it sounds somewhat ridiculous and hypothetical, so I'm fine without.

================
Comment at: openmp/libomptarget/include/device.h:558
+private:
+  std::atomic_bool RTLsLoaded = false;
+  llvm::SmallVector<__tgt_bin_desc *> DelayedBinDesc;
----------------
Nit: Shouldn't need to be atomic, but I can accept the paranoia.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142249/new/

https://reviews.llvm.org/D142249