[Openmp-commits] [PATCH] D142249: [openmp] Workaround for HSA in issue 60119

Fri Jan 20 14:46:58 PST 2023

JonChesterfield added a comment.

This is trending in the direction of D142008 <https://reviews.llvm.org/D142008>. It's essentially the same workaround but restructured aiming to minimise blast radius.

It doesn't worry about threads on the basis that whatever thread has started to initialise libomptarget is going to hold a lock in the loader until the constructor is done by which point the boolean is set.

It therefore doesn't attempt the general fix of D142008 <https://reviews.llvm.org/D142008> for various threads doing this and possibly falling over. Once the first thread has managed to stand up the plugins (or given up), the hazard we're working around is no longer a concern.

Thoughts? I'll make it prettier (rename the_snake_case, move the noise into a method on pass manager) if we think this is a reasonable path to take.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142249/new/

https://reviews.llvm.org/D142249