[Openmp-commits] [PATCH] D142145: [OpenMP][libomptarget] Fix deinit of NextGen AMDGPU plugin

Kevin Sala Penad├ęs via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 19 12:18:25 PST 2023


kevinsala added a comment.

In D142145#4066770 <https://reviews.llvm.org/D142145#4066770>, @jhuber6 wrote:

> This is fine overall, but fewer random globals lying around it always good. I don't know if it's possible to do something like `if (some_random_hsa_call && some_random_hsa_call() != HSA_STATUS_NOT_INITIALIZED)` since it default value of the pointer might not be null.



> fewer random globals lying around it always good

Not sure if you refer to the `Initialized` variable. In this case it's not a global, it's a data member of the `AMDGPUPluginTy` class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142145/new/

https://reviews.llvm.org/D142145



More information about the Openmp-commits mailing list