[Openmp-commits] [PATCH] D142145: [OpenMP][libomptarget] Fix deinit of NextGen AMDGPU plugin

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 19 11:54:11 PST 2023


jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

This is fine overall, but fewer random globals lying around it always good. I don't know if it's possible to do something like `if (some_random_hsa_call && some_random_hsa_call() != HSA_STATUS_NOT_INITIALIZED)` since it default value of the pointer might not be null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142145/new/

https://reviews.llvm.org/D142145



More information about the Openmp-commits mailing list