[Openmp-commits] [PATCH] D100186: [OpenMP] [OMPD] [6/6] Implementation of OMPD debugging library - libompd. libompd-tests: Testcases for libompd

[Jolanta Jensen via Phabricator via Openmp-commits]

jolanta.jensen added inline comments.


================
Comment at: openmp/libompd/test/api_tests/test_ompd_device_initialize.c:11-13
+}
+// CHECK-NOT: Failed
+// CHECK-NOT: Skip
----------------
These check lines do not catch OMPD module initialization failure, i.e. below output is regarded as correct one by the test:

```
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-120.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "aarch64-redhat-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from openmp/libompd/test/api_tests/Output/test_ompd_device_initialize.c.tmp...done.
Traceback (most recent call last):
  File "openmp/libompd/test/../gdb-plugin/python-module/ompd/__init__.py", line 9, in <module>
    import ompd
  File "openmp/libompd/test/../gdb-plugin/python-module/ompd/ompd.py", line 1, in <module>
    import ompdModule
ImportError: dynamic module does not define init function (initompdModule)
('Error: OMPD support could not be loaded', ImportError('dynamic module does not define init function (initompdModule)',))
openmp/libompd/test/api_tests/test_ompd_device_initialize.c.cmd:1: Error in sourced command file:
Undefined command: "ompd".  Try "help".
(gdb) quit

```

Only two of the tests added in this patch will fail if the OMPD module fails initialization, the other ones will pass.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100186/new/

https://reviews.llvm.org/D100186