[Openmp-commits] [PATCH] D142064: [OpenMP][AMDGPU] Get rid of redundant macro def

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jan 18 15:54:39 PST 2023


tianshilei1992 created this revision.
tianshilei1992 added reviewers: jdoerfert, jhuber6.
Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
tianshilei1992 requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1, wdng.
Herald added a project: OpenMP.

The next gen plugin adds the def of `DEBUG_PREFIX` in CMake, causing
compiler warning that `DEBUG_PREFIX` is defined multiple times. This patch simply
guards the macro def.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142064

Files:
  openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.cpp


Index: openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.cpp
===================================================================
--- openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.cpp
+++ openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.cpp
@@ -77,7 +77,9 @@
 #ifndef TARGET_NAME
 #error "Missing TARGET_NAME macro"
 #endif
+#ifndef DEBUG_PREFIX
 #define DEBUG_PREFIX "Target " GETNAME(TARGET_NAME) " RTL"
+#endif
 
 static bool checkForHSA() {
   // return true if dlopen succeeded and all functions found


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142064.490325.patch
Type: text/x-patch
Size: 514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230118/df31485f/attachment.bin>


More information about the Openmp-commits mailing list