[Openmp-commits] [PATCH] D142036: [OpenMP] Add HWLOC compatibility check

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked 2 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/cmake/config-ix.cmake:345
   check_include_file(hwloc.h LIBOMP_HAVE_HWLOC_H)
   set(CMAKE_REQUIRED_INCLUDES)
   find_library(LIBOMP_HWLOC_LIBRARY
----------------
jlpeyton wrote:
> Move this below the check_struct_has_member call so the same hwloc.h header is used as the one in the check_include_file() call. 
I think the logic here is, we first check if the header can be included, and then see if it is a valid one. Of course we could do it in another way. Either should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142036/new/

https://reviews.llvm.org/D142036