[Openmp-commits] [PATCH] D142045: [OpenMP][OMPT] Expect failure from tool_available_search.c on macOS

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 created this revision.
tianshilei1992 added reviewers: protze.joachim, jdoerfert.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
tianshilei1992 requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.
Herald added a project: OpenMP.

D91464 <https://reviews.llvm.org/D91464> introduced verbose tool loading, but the test check only considers Linux.
On macOS, the outputs are totally different, causing the regression afterwards.
This patch simply sets the test to XFAIL on macOS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142045

Files:
  openmp/runtime/test/lit.cfg
  openmp/runtime/test/ompt/loadtool/tool_available_search/tool_available_search.c


Index: openmp/runtime/test/ompt/loadtool/tool_available_search/tool_available_search.c
===================================================================
--- openmp/runtime/test/ompt/loadtool/tool_available_search/tool_available_search.c
+++ openmp/runtime/test/ompt/loadtool/tool_available_search/tool_available_search.c
@@ -6,11 +6,12 @@
 // RUN: OMP_TOOL_VERBOSE_INIT=stdout %libomp-run | FileCheck %s -DPARENTPATH=%T
 
 // REQUIRES: ompt
+// XFAIL: darwin
 
 /*
- *  This file contains code for three OMPT shared library tool to be 
- *  loaded and the code for the OpenMP executable. 
- *  No option enables code for the first shared library 
+ *  This file contains code for three OMPT shared library tool to be
+ *  loaded and the code for the OpenMP executable.
+ *  No option enables code for the first shared library
  *  (without an implementation of ompt_start_tool) during compilation
  *  -DTOOL -DSECOND_TOOL enables the code for the second tool during compilation
  *  -DTOOL -DTHIRD_TOOL enables the code for the third tool during compilation
@@ -45,7 +46,7 @@
 
 // Check if libomp supports the callbacks for this test.
 
-// CHECK-NOT: {{^}}0: Could not register callback 
+// CHECK-NOT: {{^}}0: Could not register callback
 // CHECK: {{^}}0: Tool initialized
 // CHECK: {{^}}0: ompt_event_thread_begin
 // CHECK-DAG: {{^}}0: ompt_event_thread_begin
@@ -90,7 +91,7 @@
   return NULL;
 }
 #elif defined(THIRD_TOOL)
-// The third tool has an implementation of ompt_start_tool that returns a 
+// The third tool has an implementation of ompt_start_tool that returns a
 // pointer to a valid instance of ompt_start_tool_result_t
 
 static void
Index: openmp/runtime/test/lit.cfg
===================================================================
--- openmp/runtime/test/lit.cfg
+++ openmp/runtime/test/lit.cfg
@@ -105,6 +105,9 @@
 if config.operating_system == 'NetBSD':
     config.available_features.add("netbsd")
 
+if config.operating_system == 'Darwin':
+    config.available_features.add("darwin")
+
 if config.operating_system in ['Linux', 'Windows']:
     config.available_features.add('affinity')
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142045.490243.patch
Type: text/x-patch
Size: 2125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230118/f85bd17e/attachment.bin>