[Openmp-commits] [PATCH] D141986: [OpenMP] RecordReplay saves bitcode when JIT-ing

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, nits



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:127
+      size_t Size = (char *)TgtImageBitcode->ImageEnd -
+                    (char *)TgtImageBitcode->ImageStart;
+      MemoryBufferRef MBR = MemoryBufferRef(
----------------
There is a helper for this in utilities now. Getptrdiff or similar


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:132
+    } else
+      OS << Image.getMemoryBuffer().getBuffer();
     OS.close();
----------------
Nit: add braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141986/new/

https://reviews.llvm.org/D141986