[Openmp-commits] [PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9098
+      CombinedInfo.Types.push_back(
+          (Cap->capturesVariable() ? OMP_MAP_TO : OMP_MAP_LITERAL) |
+          OMP_MAP_TARGET_PARAM);
----------------
tianshilei1992 wrote:
> The variable used in `has_device_addr` indicates it already has device address and can be accessed directly. Why do we need `OMP_MAP_TO` here? `OMP_MAP_TO` indicates we are gonna transfer data to the device right?
IIUC, https://reviews.llvm.org/D141627 would fix it. Could you please take a look if it makes sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134268/new/

https://reviews.llvm.org/D134268