[Openmp-commits] [PATCH] D140982: [HardwareLoops] NewPM support

[Sam Parker via Phabricator via Openmp-commits]

samparker added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:284
+  PA.preserve<DominatorTreeAnalysis>();
+  PA.preserve<LoopAnalysis>();
+  return PA;
----------------
shchenz wrote:
> Seems this is an issue from LPM, but hardware loop insertion pass should preserve some other analysis as well, like `ScalarEvolutionAnalysis`, `BranchProbabilityAnalysis`, `DependenceAnalysis` and `MemorySSAAnalysis` (although there is no handling for it now, we may need pass it to `InsertPreheaderForLoop` if want to preserve this analysis)? I saw some other pass that calls `InsertPreheaderForLoop` but declare to preserve these analysis.
I can't say I understand the LPM, but we're not using it here, nor are we using MemorySSA or BranchProbability. So could you please explain why/what you'd like to see change here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140982/new/

https://reviews.llvm.org/D140982