[Openmp-commits] [PATCH] D112270: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds

Tue Jan 10 20:54:54 PST 2023

ggouaillardet added a comment.
Herald added a project: All.

`hwloc_cpukinds_get_nr()` and friends were introduced in `hwloc` v2.4, so these changes implicitly bumps the `hwloc` version requirement to 2.4.

I suspect this was not intended.
For example, RHEL8 provides `hwloc 2.2` and requiring `hwloc` not provided by the distro is imho not desirable (for example, conflicts can occur when building a binary linked to a library (such as MPI) that depends on the distro `hwloc`.

The attached patch #ifdef protects (most) the changes when building against `hwloc` < 2.4.

F26150422: llvm15-openmp.patch <https://reviews.llvm.org/F26150422>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112270/new/

https://reviews.llvm.org/D112270