[Openmp-commits] [PATCH] D141350: Fix runtime problem for base class member data used in target region.

[Jennifer Yu via Phabricator via Openmp-commits]

jyu2 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490
+    if (MD)
+      if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(MD->getParent()))
+        HasBaseClass = RD->getNumBases() > 0;
----------------
ABataev wrote:
> `const auto *RD = dyn_cast<CXXRecordDecl>(MD->getParent())`. Also, can we use `MD->getParent()->getAsCXXRecordDecl()`?
Thank!  Changed.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8493
     // There should not be a mapper for a combined entry.
+    if (MD && HasBaseClass) {
+      // OpenMP 5.2 148:21:
----------------
ABataev wrote:
> MD is true if HasBaseClass is true
Sorry, changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141350/new/

https://reviews.llvm.org/D141350