[Openmp-commits] [PATCH] D132676: [OpenMP][Fix] Track all threads that may delete an entry

[Guilherme Valarini via Phabricator via Openmp-commits]

gValarini marked an inline comment as done.
gValarini added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:369
+                         bool &IsHostPtr, bool MustContain, bool ForceDelete,
+                         bool FromDataEnd) {
   HDTTMapAccessorTy HDTTMap = HostDataToTargetMap.getExclusiveAccessor();
----------------
ye-luo wrote:
> getTgtPtrBegin arguments are very correlated. Better to be scrutinized in the the future.
I agree. Unfortunately, the comment below is a little misleading, since `UpdateRefCount` is not always set on targetDataEnd.

> Decrement the reference counter if called from targetDataEnd.

I updated the doc comment for now and I'll add a small patch removing some of the return arguments that should be placed inside `TargetPointerResultTy` later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132676/new/

https://reviews.llvm.org/D132676