[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LG, few final nits about formatting that should be addressed.



================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2635
+  auto HostCallRequired =
+      false; // TODO set correctly once host services available
+  INFO(OMP_INFOTYPE_PLUGIN_KERNEL, GenericDevice.getDeviceId(),
----------------
Comment above line.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:139
+struct KernelMetaDataTy {
+  uint64_t kernel_object;
+  uint32_t group_segment_size;
----------------
these should all use the LLVM naming style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521