[Openmp-commits] [openmp] 9b8e4b4 - [Libomptarget] Remove unused image argument from global handler function

[Joseph Huber via Openmp-commits]

Author: Joseph Huber
Date: 2023-02-24T07:24:29-06:00
New Revision: 9b8e4b4f965200d441f3b37771bee5845e6debe5

URL: https://github.com/llvm/llvm-project/commit/9b8e4b4f965200d441f3b37771bee5845e6debe5
DIFF: https://github.com/llvm/llvm-project/commit/9b8e4b4f965200d441f3b37771bee5845e6debe5.diff

LOG: [Libomptarget] Remove unused image argument from global handler function

Summary:
A previous patch got rid of the use of this image but forgot to remove
it from this function. Simply remove it as it is unused now.

Added: 
    

Modified: 
    openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h
    openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h
index 51a6f4ffd8858..b51ed3c09759c 100644
--- a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h
+++ b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h
@@ -158,8 +158,7 @@ class GenericGlobalHandlerTy {
   /// Copy the memory associated with a global from the host to its counterpart
   /// on the device. The name, size, and origin are defined by \p HostGlobal.
   /// The destination is defined by \p DeviceGlobal.
-  Error writeGlobalToDevice(GenericDeviceTy &Device, DeviceImageTy &Image,
-                            const GlobalTy &HostGlobal,
+  Error writeGlobalToDevice(GenericDeviceTy &Device, const GlobalTy &HostGlobal,
                             const GlobalTy &DeviceGlobal) {
     return moveGlobalBetweenDeviceAndHost(Device, HostGlobal, DeviceGlobal,
                                           /* D2H */ false);

diff  --git a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
index 4a1803254d4a3..43ef2c822713f 100644
--- a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
+++ b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
@@ -518,8 +518,8 @@ Error GenericDeviceTy::registerGlobalOffloadEntry(
     // can access host addresses directly. There is no longer a
     // need for device copies.
     GlobalTy HostGlobal(GlobalEntry);
-    if (auto Err = GHandler.writeGlobalToDevice(*this, Image, HostGlobal,
-                                                DeviceGlobal))
+    if (auto Err =
+            GHandler.writeGlobalToDevice(*this, HostGlobal, DeviceGlobal))
       return Err;
   }