[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:442
+    if (auto Err = KernelInfoOrErr.takeError())
+      return Err;
+
----------------
I doubt this should be a fatal error. We should recover instead.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:202
+      KernelName =
+          V.second.toString(); // getString() returns not what you expect
+    } else if (isKey(V.first, ".sgpr_count")) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521