[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:224
+      KernelData.group_segment_size = V.second.getUInt();
+    } else if (isKey(V.first, "")) {
+    }
----------------
???


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:317
+  }
+  KernelInfoMap = Reader.getKernelInfoMap();
+  return Error::success();
----------------
pass it in instead of copying it out.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:319
+  return Error::success();
+}
 } // namespace utils
----------------
no llvm:: needed, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521