[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

Jan-Patrick Lehr via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 23 08:35:06 PST 2023


jplehr added a comment.

In D144521#4147666 <https://reviews.llvm.org/D144521#4147666>, @jhuber6 wrote:

> In D144521#4147647 <https://reviews.llvm.org/D144521#4147647>, @jplehr wrote:
>
>> Am I right to assume you mainly asking about the code that obtains the metadata for the different kernels in the image?
>> Without executing a OpenMP target offload program on an AMDGPU, I see mostly one option: Construct a msgpack from a textual representation (e.g., YAML) and query that for the relevant information. This should be somewhat straight forward to do in Google Test. But, it would not automatically react to changes in the metadata produced in the backend. For that, we probably would need to compile and run something on an AMDGPU to test the output.
>
> Shouldn't this get populated automatically if you compile an OpenMP program? We don't need to check. We have an existing `info.c` test that you could copy and make AMD only.

Yes. Apologies for me not yet being aware of the different test possibilities.
So, if we can compile / run a simple offload program to check if things get populated that would probably be even easier and account for any changes in the metadata.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521



More information about the Openmp-commits mailing list