[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:272-274
+      if (!(*It).isMap()) {
+        MESSAGE0("Array entry not a map");
+      }
----------------
jhuber6 wrote:
> jhuber6 wrote:
> > I'd guess that this should be an error. If we fail to parse the code object something is probably wrong.
> 
I'm not sure if it should be an error, but if it is not a map, we should probably skip it (and maybe warn or so). I'm not familiar enough with the msgpack format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521