[Openmp-commits] [PATCH] D142175: [OpenMP] Create a temp file in /tmp if /dev/shm is not accessible

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:6920
+    KMP_DEBUG_ASSERT(temp_reg_status_file_name);
+    FILE *tf = fopen(temp_reg_status_file_name, O_RDONLY);
+    if (!tf) {
----------------
sthibaul wrote:
> This is very obviously wrong (mixing `fopen` and `O_RDONLY`), and doesn't build:
> 
> ```
> /<<PKGBUILDDIR>>/openmp/runtime/src/kmp_runtime.cpp:6920:16: error: no matching function for call to 'fopen'
>     FILE *tf = fopen(temp_reg_status_file_name, O_RDONLY);
>                ^~~~~
> /usr/include/stdio.h:270:26: note: candidate function not viable: no known conversion from 'int' to 'const char *__restrict' for 2nd argumen
> extern FILE *__REDIRECT (fopen, (const char *__restrict __filename,
> ```
> 
> Actually, why using fopen at all? Rather use 
> 
> ```
> fd1 = open(temp_reg_status_file_name, O_RDONLY);
> if (fd1 == -1) {
>   // give it up now
>   return;
> }
> ```
> 
> ?
Thanks for pointing that out. I should have caught that. I'll fix it right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142175/new/

https://reviews.llvm.org/D142175