[Openmp-commits] [PATCH] D142569: [OpenMP] Introduce kernel environment

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3917
+
+  Twine DynamicEnvironmenttName = KernelName + "_dynamic_environment";
+  Constant *DynamicEnvironmentInitializer =
----------------
Typo: `tt`


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:583
+  if (!KernelEnvOrError)
+    return KernelEnvOrError.takeError();
+
----------------
We used to default to SPMD w/o a _exec_mode. Unsure if this will cause problems. I am inclined to allow missing _kernel_env as well and use SPMD then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142569/new/

https://reviews.llvm.org/D142569