[Openmp-commits] [PATCH] D144419: Improvements to the OpenMP Windows build

[Vadim Paretsky via Phabricator via Openmp-commits]

vadikp-intel added a comment.

Yes, clang-cl style builds are a known open issue, we are looking at patching llvm-lib.

The intent of this change is to switch applications built with OpenMP to importing by name, rather than ordinal from the runtime. This way, e.g. someone who find themselves in conflict when adding a new API can just move it to a different ordinal without breaking anything for anyone. I am not sure there's been a particular established procedure of assigning ordinals to new OpenMP APIs, but after this change it should not matter, and I think 'dllexport' has already not even technically required ordinals on APIs for the build to succeed. In other words.

I think the step is about builds that follow the "native" Windows import library model and have changed the description to say that. 'MSVC style' is OK too, but I think the term is a bit vague and imprecise, e.g. you can build Windows DLLs with import libraries from assembly code as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144419/new/

https://reviews.llvm.org/D144419