[Openmp-commits] [PATCH] D143992: [openmp] Fix building for mingw targets after import library changes

Tue Feb 14 14:22:56 PST 2023

mstorsjo added a comment.

In D143992#4127289 <https://reviews.llvm.org/D143992#4127289>, @vadikp-intel wrote:

> The patch looks OK to fix the mingw build for now.

Ok, thanks! Would you mind marking it as approved, before I go ahead and commit it?

> We have work in flight to address a few issues brought up here, e.g. kmp_import, the need to build the second set of sources and .def support outside of the MSVC compatible toolsets (e.g. llvm-lib) that may further touch on this particular script.

Ok, that sounds good to hear! Feel free to subscribe me to such patches, and I'll try to chime in if I have something to add on it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143992/new/

https://reviews.llvm.org/D143992