[Openmp-commits] [PATCH] D143991: [openmp] Fix building with MSVC for ARM64

Martin Storsjö via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Feb 14 01:55:50 PST 2023

mstorsjo created this revision.
mstorsjo added reviewers: branh, natgla, tianshilei1992, jdoerfert, jlpeyton.
Herald added subscribers: guansong, kristof.beyls, yaxunl.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

This fixes a typo from 7a795c42ad7f003cd454bf8dbab714714425664c <https://reviews.llvm.org/rG7a795c42ad7f003cd454bf8dbab714714425664c>
(https://reviews.llvm.org/D139139). Apparently some codepaths in
that commit weren't actually ever test compiled, since they
can't have worked due to misbalanced parentheses.

Building with Clang (both mingw mode and clang-cl) didn't use
these codepaths, so building in that mode did work.

  rG LLVM Github Monorepo



Index: openmp/runtime/src/kmp_os.h
--- openmp/runtime/src/kmp_os.h
+++ openmp/runtime/src/kmp_os.h
@@ -610,7 +610,7 @@
 #define KMP_XCHG_FIXED8(p, v)                                                  \
   _InterlockedExchange8((volatile kmp_int8 *)(p), (kmp_int8)(v));
 #define KMP_XCHG_FIXED16(p, v) _InterlockedExchange16((p), (v));
-#define KMP_XCHG_REAL64(p, v) __kmp_xchg_real64((p), (v)));
+#define KMP_XCHG_REAL64(p, v) __kmp_xchg_real64((p), (v));
 inline kmp_real64 __kmp_xchg_real64(volatile kmp_real64 *p, kmp_real64 v) {
   kmp_int64 tmp = _InterlockedExchange64((volatile kmp_int64 *)p, *(kmp_int64

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143991.497242.patch
Type: text/x-patch
Size: 681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230214/f6bcc3ad/attachment.bin>

More information about the Openmp-commits mailing list