[Openmp-commits] [PATCH] D143431: Switch the Windows OpenMP import library to import by name rather than ordinal.

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo added inline comments.


================
Comment at: openmp/runtime/src/CMakeLists.txt:289
-    # Create new import library that is just the previously created one + kmp_import.cpp
-    add_library(ompimp STATIC ${LIBOMP_GENERATED_IMP_LIB} kmp_import.cpp)
-    set_target_properties(ompimp PROPERTIES
----------------
mstorsjo wrote:
> Previously, the finally installed import library contained the compiled `kmp_import.cpp` too, which contains symbols like `_You_must_link_with_exactly_one_OpenMP_library`. These are now lost.
Sorry, I see that this particular aspect was actually already discussed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143431/new/

https://reviews.llvm.org/D143431