[Openmp-commits] [PATCH] D143775: [Libomptarget] Implement the host memory allocator with coarse memory

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Feb 13 04:57:51 PST 2023


jhuber6 added a subscriber: grokos.
jhuber6 added a comment.

In D143775#4122420 <https://reviews.llvm.org/D143775#4122420>, @JonChesterfield wrote:

> I believe coarse/fine grain and accessibility are orthogonal concepts. If the coarse grain pool happens to have the accessibility properties of "target_host", then it'll work. That may be target specific and even order of pool iteration specific.
>
> Much safer would be to identify a memory pool with the properties that the given allocator specifies and return that. Coarse grain means synchronised on kernel boundaries iiuc.
>
> So what is a target_host_mem allocator?

Yeah, I think the problem is that `target_host_mem_alloc` was never fully defined by @grokos. I interpreted it to mean that it's pinned memory that the device can access. I'm pretty sure coarse memory fits the bill there, but I don't know what the exact intention was with the "non-migratable" sentence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143775/new/

https://reviews.llvm.org/D143775



More information about the Openmp-commits mailing list