[Openmp-commits] [PATCH] D142593: [OpenMP] Support for wasm32 architecture

Fri Feb 3 08:14:06 PST 2023

tianshilei1992 added a comment.

In D142593#4102328 <https://reviews.llvm.org/D142593#4102328>, @arsnyder16 wrote:

> In D142593#4101532 <https://reviews.llvm.org/D142593#4101532>, @tianshilei1992 wrote:
>
>> Is it feasible to test it somehow? I doubt the regular way to invoke tests can work with WASM.
>
> Yes, the compiled wasm can be run through node. In our product we use gtest and we only ship our wasm in the browser so we build the gtest projects using emrun so we test within a headless chrome browser.
>
> I think node would make sense here. Which tests specifically would you like to get working? runtime/test?  Can you point me to any docs or examples of running the tests. As i get time i can poke at working through that.

The whole LLVM project depends on LIT test (https://llvm.org/docs/CommandGuide/lit.html). The LIT configuration for `libomp` is in `openmp/runtime/test/lit.cfg` and `openmp/runtime/test/lit.site.cfg.in`.

I think for the testing infrastructure, you might need CMake to check the existence of node (silently), and then replace those `RUN` lines accordingly (by those LIT configuration).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142593/new/

https://reviews.llvm.org/D142593