[Openmp-commits] [PATCH] D143200: [OpenMP][libomp] Fix CMake version symbol testing

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton updated this revision to Diff 494429.
jlpeyton added a comment.

Some linkers error out with a wildcard in both the global and local section under a version symbol. Removed the local part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143200/new/

https://reviews.llvm.org/D143200

Files:
  openmp/runtime/cmake/config-ix.cmake
  openmp/runtime/src/exports_test_so.txt


Index: openmp/runtime/src/exports_test_so.txt
===================================================================
--- openmp/runtime/src/exports_test_so.txt
+++ openmp/runtime/src/exports_test_so.txt
@@ -19,10 +19,6 @@
 
         *;         # All symbols as exported for testing.
 
-    local: # Non-exported symbols.
-
-        *;         # All other symbols are not exported.
-
 }; # VERSION
 
 # sets up GCC OMP_ version dependency chain
Index: openmp/runtime/cmake/config-ix.cmake
===================================================================
--- openmp/runtime/cmake/config-ix.cmake
+++ openmp/runtime/cmake/config-ix.cmake
@@ -246,7 +246,11 @@
 
 # Checking features
 # Check if version symbol assembler directives are supported
-libomp_check_version_symbols(LIBOMP_HAVE_VERSION_SYMBOLS)
+if (LIBOMP_HAVE_VERSION_SCRIPT_FLAG)
+  libomp_check_version_symbols(LIBOMP_HAVE_VERSION_SYMBOLS)
+else()
+  set(LIBOMP_HAVE_VERSION_SYMBOLS FALSE)
+endif()
 
 # Check if quad precision types are available
 if(CMAKE_C_COMPILER_ID STREQUAL "GNU")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143200.494429.patch
Type: text/x-patch
Size: 1047 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230202/dd26e8cb/attachment.bin>