[Openmp-commits] [PATCH] D143192: [Libomptarget] Improve next-gen AMDGPU plugin error messages

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2435
     uint32_t ReasonsMask = Event->memory_fault.fault_reason_mask;
     if (ReasonsMask & HSA_AMD_MEMORY_FAULT_PAGE_NOT_PRESENT)
+      Reasons.emplace_back("Page not present or supervisor privilege");
----------------
arsenm wrote:
> Is it really possible to have multiple of these hit at a time?
Yes, but I think the only one I'm aware of is a typical segfault will present `HSA_AMD_MEMORY_FAULT_PAGE_NOT_PRESENT` and `HSA_AMD_MEMORY_FAULT_READ_ONLY` at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143192/new/

https://reviews.llvm.org/D143192