[Openmp-commits] [openmp] [OpenMP][libomptarget] Enable automatic unified shared memory executi… (PR #75999)

Johannes Doerfert via Openmp-commits openmp-commits at lists.llvm.org
Tue Dec 19 19:47:24 PST 2023

@@ -2913,7 +2913,7 @@ struct AMDGPUPluginTy final : public GenericPluginTy {
   /// Create an AMDGPU plugin and initialize the AMDGPU driver.
       : GenericPluginTy(getTripleArch()), Initialized(false),
-        HostDevice(nullptr) {}
+        HostDevice(nullptr), IsAPU(false), OMPX_HSAXnack("HSA_XNACK", false) {}
jdoerfert wrote:

(I wrote this before I saw Shilei's comment)
I understand you followed existing code but I think we should (maybe in a pre-commit) move these initializations to the member definition. It's cumbersome to have them here, in order, as one needs to look at 2 places to understand type and initial value. 


More information about the Openmp-commits mailing list