[Openmp-commits] [openmp] [Libomptarget] Remove __tgt_image_info and use the ELF directly (PR #75720)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 18 07:09:20 PST 2023

jhuber6 wrote:

> This patch doesn't seem to work with `clang -O2 -fopenmp --offload-arch=gfx90a:sramecc+:xnack- --offload-arch=gfx90a:sramecc+:xnack+ helloworld.c -o helloworld`
> HSA_XNACK=1 ./helloworld HSA_XNACK=0 ./helloworld
> Both of them should work on a system which allows HSA_XNACK toggling on per process basis.
> I have couple of more concerns for which I am trying to get counter cases.

So, the desired behavior here is that the prior should reject `xnack-` while the latter should reject `xnack+`. I think in the logic I only check if the opposite is set for returning an invalid image, but it seems I need to check that the target ID contains the equivalent value.


More information about the Openmp-commits mailing list